Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create-react-context v0.2.3 licence terms deny use on certain organizations. #635

Closed
jkarttunen opened this issue Dec 4, 2018 · 4 comments
Closed

Comments

@jkarttunen
Copy link

@jkarttunen jkarttunen commented Dec 4, 2018

Is your feature request related to a problem? Please describe.
create-react-context v0.2.3 licence prohibits usage of CRC for certain organizations.
Even though the licence terms have been updated, the version has not been incremented and npm servers the old licence version.

Describe the solution you'd like
Can we use the latest commit of crc, instead of the npm published one?
Or update Reacti18next licence terms to match CRC licence.

Describe alternatives you've considered
Or fork crc and publish on npm.

@jamuhl

This comment has been minimized.

Copy link
Member

@jamuhl jamuhl commented Dec 4, 2018

jamiebuilds/create-react-context@f31c9ed#r31551322

hopefully we get a version 0.2.4 - would be prefer to just bump that instead of forking.

Alternative would be removing the polyfill and leave that to userland. Will give them some time to publish and if no response will consider that.

@rhinoceraptor

This comment has been minimized.

Copy link

@rhinoceraptor rhinoceraptor commented Dec 14, 2018

Are there any plans to just require React 16.3 and use the new React context API?

@jamuhl

This comment has been minimized.

Copy link
Member

@jamuhl jamuhl commented Dec 15, 2018

@rhinoceraptor yes that is the fallback plan for v9

@jamuhl

This comment has been minimized.

Copy link
Member

@jamuhl jamuhl commented Dec 31, 2018

removed create-react-context in react-i18next@9.0.0 -> upgrade of react to v16.3 needed (or polyfill in userland)

@jamuhl jamuhl closed this Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.