Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SAMOptions to I2PListener #19

Closed
a-0-dev opened this issue Nov 16, 2023 · 2 comments
Closed

Expose SAMOptions to I2PListener #19

a-0-dev opened this issue Nov 16, 2023 · 2 comments

Comments

@a-0-dev
Copy link

a-0-dev commented Nov 16, 2023

I would like to have access to manually setting the SAMOptions for my I2PListener. Before I go ahead and code something for a PR, would the following approach be okay for you?

Since there are already different functions for creating an I2PListener, I would implement an I2PListenerBuilder where one can first set all options as one likes and then calling a build() function on that builder returns the I2PListener just as the different bind functions do it now.

If you have any other suggestion, I'm happy to hear about it and will try to integrate it. I'm planning on using this lib for a personal project of mine, I'm happy to contribute something as well :)

@eyedeekay
Copy link
Contributor

Please feel free to implement your proposal and make a PR at any time.

@a-0-dev
Copy link
Author

a-0-dev commented Nov 25, 2023

Implemented in #20

@a-0-dev a-0-dev closed this as completed Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants