Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Hardcoded, Security-relevant Constants #64

Closed
s-b-repo opened this issue Oct 17, 2023 · 1 comment
Closed

Use of Hardcoded, Security-relevant Constants #64

s-b-repo opened this issue Oct 17, 2023 · 1 comment

Comments

@s-b-repo
Copy link

private static final String PROP_LS_SPK = "i2cp.leaseSetSigningPrivateKey";
// LS 2
public static final String PROP_LS_TYPE = "i2cp.leaseSetType";
private static final String PROP_LS_ENCTYPE = "i2cp.leaseSetEncType";
private static final String PROP_SECRET = "i2cp.leaseSetSecret";

line:70
Avoid hardcoding values that are meant to be secret. Found hardcoded secret.

core/java/src/net/i2p/client/impl/RequestLeaseSetMessageHandler.java#L70)

@eyedeekay
Copy link
Contributor

Not a bug. This is a the name of a property which is stored in a configuration file, format would be i2cp.leaseSetSecret=secret. It is not the value of the property, which is the actual secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants