(Unlikely) memory leak in xcb_query_text_width

[psychon]

i3/libi3/font.c

Lines 427 to 444 in 2d6e09a

	/* Query the text width */
	xcb_generic_error_t *error;
	xcb_query_text_extents_cookie_t cookie = xcb_query_text_extents(conn,
	savedFont->specific.xcb.id, text_len, (xcb_char2b_t *)text);
	xcb_query_text_extents_reply_t *reply = xcb_query_text_extents_reply(conn,
	cookie, &error);
	if (reply == NULL) {
	/* We return a safe estimate because a rendering error is better than
	* a crash. Plus, the user will see the error in their log. */
	fprintf(stderr, "Could not get text extents (X error code %d)\n",
	error->error_code);
	return savedFont->specific.xcb.info->max_bounds.character_width * text_len;
	}
	int width = reply->overall_width;
	free(reply);
	return width;
	}

What happened to free(error) inside reply == NULL?

[i3bot]

I don’t see a link to logs.i3wm.org. Did you follow https://i3wm.org/docs/debugging.html? (In case you actually provided a link to a logfile, please ignore me.)

[i3bot]

I don’t see a version number. Could you please copy & paste the output of i3 --version into this issue?