Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Remove APKTOOL_DUMMY #2683

Closed
pashamcr opened this issue Oct 18, 2021 · 2 comments
Closed

[FEAT] Remove APKTOOL_DUMMY #2683

pashamcr opened this issue Oct 18, 2021 · 2 comments

Comments

@pashamcr
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Apktool creates a lot of unnecessary APKTOOL_DUMMY, which means nothing but empty space, but in the output file they take up space as dead weight.

Describe the solution you'd like
Delete or comment out the code chunks that cause APKTOOL_DUMMY.

Additional context
For example, apk https://www.apkmirror.com/apk/google-inc/gboard/gboard-10-9-03-387080390-release/gboard-the-google-keyboard-10-9-03-387080390-lite_release-arm64-v8a-android-apk-download/
aapt2 dump resources Gboard.apk > res.txt
for three apks: original, re-compiled, and re-compiled using apktool without APKTOOL_DUMMY.
Compare logs res.txt which one is closer to the original? In addition, the output file size increases
: original 33.0 mb, output with APKTOOL_DUMMY 33.4 mb, without APKTOOL_DUMMY 33.1 mb
res.txt
res_dummy.txt
res_nodummy.txt

@iBotPeaches
Copy link
Owner

We tried this once and I was hesitant, maybe for 3.0. Marking as feature.

Repository owner locked and limited conversation to collaborators Jul 17, 2023
@iBotPeaches iBotPeaches converted this issue into discussion #3159 Jul 17, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@iBotPeaches @pashamcr and others