Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #3400

Closed
starbucks2010 opened this issue Oct 13, 2023 · 5 comments · Fixed by #3404
Closed

[BUG] #3400

starbucks2010 opened this issue Oct 13, 2023 · 5 comments · Fixed by #3404
Milestone

Comments

@starbucks2010
Copy link

starbucks2010 commented Oct 13, 2023

Information

  1. Apktool Version (apktool -version) - 2.9.0
  2. Operating System (Mac, Linux, Windows) - Windows
  3. APK From? (Playstore, ROM, Other) - ROM
  4. Java Version (java --version) - 20.0.2

Stacktrace/Logcat

C:\apktool>java -jar apktool-2.9.0-20231009.jar d framework-res_g988b_hwi7.apk
I: Using Apktool 2.9.0 on framework-res_g988b_hwi7.apk
I: Loading resource table...
I: Decoding file-resources...
I: Decoding values / XMLs...
I: Decoding AndroidManifest.xml with resources...
I: Regular manifest package...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...

Steps to Reproduce

  1. Decompile the framework-res.apk and check res/values/styles.xml file for duplicated lines (lines 1236-1237, 1313-1314, 1322-1323, 1324-1325, 2505-2506, 7108-7109). It always gets duplicated the same lines.

Frameworks

If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files

Use the attached framework file.

APK

If this APK can be freely shared, please upload/attach a link to it.

Questions to ask before submission

  1. Have you tried apktool d, apktool b without changing anything? - Yes, same issue
  2. If you are trying to install a modified apk, did you resign it? - No apk resign
  3. Are you using the latest apktool version? - Yes
    framework-res_g988b_hwi7.zip
@iBotPeaches
Copy link
Owner

@starbucks2010 - Am I correct you are only reporting the duplicates? Best I can tell in my research is these are duplicate in the entry table and Apktool is simply respecting that.

@starbucks2010
Copy link
Author

yes, only duplicates lines in styles.xml.
is there any chance to check/fix the entry table for these duplicates?

thank you

@iBotPeaches
Copy link
Owner

Not positive. I'll spend an hour and if not - close it out.

@iBotPeaches
Copy link
Owner

Okay wasn't hard to add. PR linked above - we will dedupe attribute names ignoring whatever the duplicate one is.

iBotPeaches added a commit that referenced this issue Oct 16, 2023
@iBotPeaches iBotPeaches added this to the v2.9.1 milestone Oct 16, 2023
@starbucks2010
Copy link
Author

thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants