Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract into ApkInvoker and split into data classes. #3124

Merged
merged 5 commits into from Jul 3, 2023
Merged

Extract into ApkInvoker and split into data classes. #3124

merged 5 commits into from Jul 3, 2023

Conversation

sv99
Copy link
Contributor

@sv99 sv99 commented Jul 3, 2023

Sorry for massive changes!

  1. extract new class AaptInvoker
  2. rename MetaFile to ApkInfo and rename meta namespace to apk
  3. rename AndrolibResources to the ResourcesDecoder - name unification
  4. rename private config to mConfig
  5. extract internal classes ARSCData and FlagsOffset from the ARSCDecoder
  6. move decodeManifest and decodeResources to the ResourcesDecoder
  7. minimize public API in all decoder classes
  8. move you data classes to data namespace

rebased

@iBotPeaches
Copy link
Owner

okay give me a few days on this one :)

iBotPeaches
iBotPeaches approved these changes Jul 3, 2023
View reviewed changes
Copy link
Owner

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor things I'll clean up in a follow up PR. Would rather get this merged and fix a few things then hold up a 40 file PR.

@iBotPeaches iBotPeaches changed the title Extract aaptinvoke2 Extract into ApkInvoker and split into data c;asses. Jul 3, 2023
@iBotPeaches iBotPeaches changed the title Extract into ApkInvoker and split into data c;asses. Extract into ApkInvoker and split into data classes. Jul 3, 2023
@iBotPeaches iBotPeaches merged commit a7e2e3e into iBotPeaches:master Jul 3, 2023
28 checks passed
iBotPeaches added a commit that referenced this pull request Jul 3, 2023
@iBotPeaches
docs: update changelog for #3124
737df1e
@iBotPeaches iBotPeaches added this to the v2.8.0 milestone Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBotPeaches iBotPeaches iBotPeaches approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sv99 @iBotPeaches