Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocaleNumberSystem + ConfigFlag reading #3205

Merged
merged 8 commits into from Jul 23, 2023
Merged

Conversation

iBotPeaches
Copy link
Owner

@iBotPeaches iBotPeaches commented Jul 23, 2023

During operations where we have more bytes than known (Upside down Cake). We improperly leveraged size even if we read over that. Additionally had to review some missing support on localeNumbering, which we always skipped.

@iBotPeaches iBotPeaches changed the title Prevent overreading Res Configs Fix LocaleNumberSystem + ConfigFlag reading Jul 23, 2023
@iBotPeaches iBotPeaches marked this pull request as ready for review July 23, 2023 21:18
@iBotPeaches iBotPeaches merged commit d1a0c94 into master Jul 23, 2023
31 checks passed
@iBotPeaches iBotPeaches deleted the issue-3202-overread branch July 23, 2023 21:25
iBotPeaches added a commit that referenced this pull request Jul 23, 2023
@iBotPeaches iBotPeaches added this to the v2.8.2 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant