Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit ResFileDecoder initialization in the decodeResources #3211

Merged
merged 1 commit into from Jul 24, 2023

Conversation

sv99
Copy link
Contributor

@sv99 sv99 commented Jul 24, 2023

AXmlResourceParser always set initialized ResAttrDecoder.

Add constructors ResAttrDecoder, AXmlResourceParser(ResTable resTable) and AndroidManifestResourceParser(ResTable resTable) for direct initialization resTable.

@sv99
Copy link
Contributor Author

sv99 commented Jul 24, 2023

With manual ApkInfo serialization we may move mApkFile in the ApkInfo and consolidate all check methods in the ApkInfo class (hasResource, hasManifest and other)

Copy link
Owner

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was slightly worried that we may have made a breaking change in AXmlResourceParser as there is no way to initialize that class without a Resource Table now.

However, it seems like we've never done that and no one probably directly called this class.

…eParser(ResTable resTable) and AndroidManifestResourceParser(ResTable resTable)
@sv99 sv99 force-pushed the streamline_decode_resources branch from 8e942f9 to 0b8a0b8 Compare July 24, 2023 10:28
@sv99
Copy link
Contributor Author

sv99 commented Jul 24, 2023

AXmlResourceParser always used and initialized ResAttrDecoder which always initialized with resource table

@iBotPeaches iBotPeaches merged commit c2ddeac into iBotPeaches:master Jul 24, 2023
31 checks passed
@iBotPeaches iBotPeaches added this to the v2.8.2 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants