Move to XMLUnit Legacy #3235
Merged
Move to XMLUnit Legacy #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old location of XMLUnit has ended. The proper path here is to migrate towards XMLUnit 2.x, but it looks like a challenge to rewrite our XML diff.
For now, a jump to the 2.x port of v1 can gain us an XXE Protection in case malicious test files exist during the build (of apktool). Which honestly I don't think would ever happen as if you have to control of a system that is building apktool itself and have the power to edit/change XML files - you could do more damage.
Part of me also wants to go into a CVE rant about honestly garbage CVEs, but lets upgrade this with 1 line changed to "quiet" some garbage automated scan and be done with this.