Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove db_conf.py #12

Open
dhimmel opened this issue Dec 23, 2015 · 2 comments
Open

Remove db_conf.py #12

dhimmel opened this issue Dec 23, 2015 · 2 comments

Comments

@dhimmel
Copy link
Collaborator

dhimmel commented Dec 23, 2015

Would it make more sense to have the user provide the database configuration rather than having it hardcoded as a module?

@Suor, if so what is the best way to go about accomplishing this?

@Suor
Copy link
Collaborator

Suor commented Dec 23, 2015

We are going to remove db access anyway and replace it with API. All read access to API could go without authorization, so anyone could just fetch data and make their calculations. To write to server one will need an active login.

The best practice for this case is authenticate anyone when he requires access and store token, then use this token for all the requests.

@Suor
Copy link
Collaborator

Suor commented Dec 23, 2015

For now db_conf.py is ok. It probably shouldn't be placed inside a package though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants