Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default encoding steering parameter is obsolete in SimpleFCalDigi #100

Closed
dudarboh opened this issue Oct 13, 2021 · 0 comments · Fixed by #129
Closed

Default encoding steering parameter is obsolete in SimpleFCalDigi #100

dudarboh opened this issue Oct 13, 2021 · 0 comments · Fixed by #129

Comments

@dudarboh
Copy link
Member

Using CellIDDecoder<SimCalorimeterHit>::setDefaultEncoding() is obsolete and does nothing:

https://github.com/iLCSoft/LCIO/blob/master/src/cpp/include/UTIL/CellIDDecoder.h#L104-L105

SimpleFCalDigi used steering parameter as an input to the setDefaultEncoding() here:

MarlinReco/CaloDigi/LDCCaloDigi/src/SimpleFCalDigi.cc

Line 109 in 48c3c1c

CellIDDecoder<SimCalorimeterHit>::setDefaultEncoding(_defaultEncoding.c_str()) ;

which is being fixed by the #99.

Thus making steering parameter obsolete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fill relation type information in FCal digitizer tmadlener/MarlinReco
1 participant
@dudarboh