Wrong units of TPC parameters in KinkFinder

[dudarboh]

Issue

As spotted by @tmadlener here KinkFinder uses TPC parameters without specifying specific units.

MarlinReco/Tracking/KinkFinder/src/KinkFinder.cc

Lines 198 to 201 in 39201c6

	_tpcInnerR = tpc->rMinReadout;
	_tpcOuterR = tpc->rMaxReadout;
	_tpcZmax = tpc->driftLength;
	_tpcMaxRow = tpc->maxRow;

Program is probably expects values to be in dd4hep::mm, however they are in dd4hep::cm.
I checked them with cout to confirm that they are indeed in cm:

[ VERBOSE "MyKinkFinder"] _tpcInnerR: 37.21
[ VERBOSE "MyKinkFinder"] _tpcOuterR: 169.21
[ VERBOSE "MyKinkFinder"] _tpcZmax: 222.5
[ VERBOSE "MyKinkFinder"] _tpcMaxRow: 220

It is definitely bug here1 and here2 while counting number of TPC hits. As TrackerHit::getPosition() returns coordinates in mm.

it is potentially bug here as well, as rkink gets its value from HelixClass::getPointInZ() which probably returns point in mm while comparing to values in cm

Relevance

Affects master