Strange init_ilcinstall.sh

[petricm]

After all the changes now the init script looks a bit different and maybe few things look a bit strange and need clenup

checkout /cvmfs/clicdp.cern.ch/iLCSoft/builds/nightly/x86_64-slc6-gcc62-opt/init_ilcsoft.sh

The ROOT section is gone

      57 #--------------------------------------------------------------------------------
      58 #     CLHEP
      59 #--------------------------------------------------------------------------------
      60 export CLHEP="/cvmfs/clicdp.cern.ch/software/CLHEP/2.3.1.1/x86_64-slc6-gcc62-opt"
      61 export CLHEP_BASE_DIR="$CLHEP"
      62 export CLHEP_INCLUDE_DIR="$CLHEP/include"
      63 # --- additional CLHEP commands ------- 
      64 export PATH="$CLHEP_BASE_DIR/bin:$PATH"
      65 export LD_LIBRARY_PATH="$CLHEP_BASE_DIR/lib:$LD_LIBRARY_PATH"
      66 # --- additional ROOT commands ------- 
      67 test -r /cvmfs/clicdp.cern.ch/software/ROOT/6.08.00/x86_64-slc6-gcc62-opt/bin/thisroot.sh && . /cvmfs/clicdp.cern.ch/software/ROOT/6.08.00/x86_64-slc6-gcc62-opt/bin/thisroot.sh
      68 

Eigen

      96 #--------------------------------------------------------------------------------
      97 #     CMake
      98 #--------------------------------------------------------------------------------
      99 # --- additional CMake commands ------- 
     100 export PATH="/cvmfs/clicdp.cern.ch/software/CMake/3.14.3/x86_64-slc6-gcc62-opt/bin:$PATH"
     101 # --- additional Eigen commands ------- 

DDKalTest

     171 #--------------------------------------------------------------------------------
     172 #     DD4hep
     173 #--------------------------------------------------------------------------------
     174 export DD4HEP="/cvmfs/clicdp.cern.ch/iLCSoft/builds/nightly/x86_64-slc6-gcc62-opt/DD4hep/HEAD"
     175 export DD4HEP_ENVINIT="${DD4HEP}/bin/thisdd4hep.sh"
     176 # --- additional DD4hep commands ------- 
     177 test -r ${DD4HEP_ENVINIT} && . ${DD4HEP_ENVINIT}
     178 # --- additional DDKalTest commands ------- 

     214 #--------------------------------------------------------------------------------
     215 #     PandoraPFANew
     216 #--------------------------------------------------------------------------------
     217 export PANDORAPFANEW="/cvmfs/clicdp.cern.ch/iLCSoft/builds/nightly/x86_64-slc6-gcc62-opt/PandoraPFANew/HEAD"
     218 # --- additional PandoraPFANew commands ------- 
     219 export LD_LIBRARY_PATH="$PANDORAPFANEW/lib:$LD_LIBRARY_PATH"
     220 # --- additional MarlinTrk commands ------- 
     221 # --- additional KalDet commands ------- 
     222 # --- additional MarlinReco commands ------- 
     223 # --- additional MarlinKinfit commands ------- 

The additional commands should be only written when the section exists, and the ROOT section is missing.

[rete]

Hi Marko,

• "ROOT is gone": ROOT doesn't export any variable anymore, because everything is populated by thisroot.sh. So there is not section anymore.
• "Additional commands": I agree this looks a bit messy. If there is no additional command it should not be printed out.

I'm currently tagging software versions for the next release (see #79 )
Can you provide a pull request for this issue ?