Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FCCee_o2_v01: detector model with smaller beampipe and closer vertex … #236

Merged
merged 2 commits into from
May 23, 2019
Merged

FCCee_o2_v01: detector model with smaller beampipe and closer vertex … #236

merged 2 commits into from
May 23, 2019

Conversation

eleogran
Copy link
Contributor

@eleogran eleogran commented May 22, 2019 •
edited

…subdet

BEGINRELEASENOTES

  • FCCee_o2_v01: new detector model with smaller beampipe radius (10 mm instead of 15 mm) and closer vertex subdetector

ENDRELEASENOTES

@rete
Copy link
Contributor

rete commented May 22, 2019

Please, can you fill the release notes message according to your changes ? Thanks.

@andresailer
Copy link
Contributor

Could you please also add a test for the detector in lcgeoTests/CMakeLists.txt

@rete rete self-requested a review May 22, 2019 12:11
@andresailer andresailer merged commit 8c50d17 into key4hep:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

@rete rete Awaiting requested review from rete

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eleogran @rete @andresailer