Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SiD_o2_v04 #252

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Create SiD_o2_v04 #252

merged 5 commits into from
Jun 9, 2022

Conversation

protopopescu
Copy link
Contributor

@protopopescu protopopescu commented Jun 8, 2022 •
edited

BEGINRELEASENOTES

  • Added SiD_o2_v04, which is an updated version of o2_v03, containing a few fixes, among which
    • correct size and position of ECal layer 0 via new driver ECalBarrel_o2_v04_geo.cpp
    • new beam pipe by Chris Potter
    • removed brass HCal option

ENDRELEASENOTES

@andresailer andresailer changed the title Create README.md Create SiD_o2_v03 Jun 8, 2022
@andresailer andresailer changed the title Create SiD_o2_v03 Create SiD_o2_v04 Jun 8, 2022
@protopopescu protopopescu marked this pull request as draft June 8, 2022 17:05
@protopopescu protopopescu marked this pull request as ready for review June 8, 2022 19:08
@protopopescu
Copy link
Contributor Author

protopopescu commented Jun 8, 2022 •
edited

Thanks Andre for changing the title, and for keeping an eye on this. I've committed all changes I wanted to do at this time, so this is ready for merging from my point of view.

@protopopescu protopopescu requested a review from a team June 9, 2022 07:56
@protopopescu
Copy link
Contributor Author

Who's supposed to approve this merge?

@protopopescu protopopescu removed the request for review from a team June 9, 2022 11:53
@andresailer
Copy link
Contributor

Whats the new thing for ECalBarrel_o2_v04_geo.cpp?

@andresailer andresailer merged commit 032c4cc into master Jun 9, 2022
@andresailer andresailer deleted the protopopescu-patch-1 branch June 9, 2022 14:10
@protopopescu
Copy link
Contributor Author

protopopescu commented Jun 9, 2022 •
edited

Hi Andre, thank you for merging this, and for cleaning up the patch-1 branch. This v04 driver implements a corrected ECal layer 0 size and position, as requested by UOregon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@protopopescu @andresailer