Final review #9
Final review #9
Conversation
Set parameters for products
Unit tests
Unit tests
Unit tests
✅ Deploy Preview for dapper-piroshki-bed780 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Hi @iLynette,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
Suggested changes
Check the comments under the review.
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
README.md
Outdated
|
|
||
| - Hat tip to anyone whose code was used | ||
| - Inspiration | ||
| - etc |
There was a problem hiding this comment.
- In this
Acknowledgementssection kindly give an appropriate credit to Nelson Sakwa the author of the original design, as required by the Creative Commons License.
There was a problem hiding this comment.
Thank you for the review, @elyor-doniyorov i have resolved this
| ## 📝 License | ||
|
|
||
| This project is [MIT](./MIT.md) licensed. |
There was a problem hiding this comment.
- Also please make sure the MIT license link works because this makes your Readme file professional.
public/robots.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| # https://www.robotstxt.org/robotstxt.html | |||
There was a problem hiding this comment.
- Kindly remove all the boilerplates created by the CRA (texts, images, styles) from your
srcandpublicfolders because you don't use them.
| import Categories from './Categories'; | ||
| import Btn from './Arrow'; | ||
|
|
||
| const HomePage = () => { |
There was a problem hiding this comment.
- I would suggest that your Homepage can be more centered because on my side it looks like this 👇
And I guess that is because your screen zoom was below 100% when you were designing. Because when my screen zoom is 90% it looks perfect like one in your video.
| import { HiMicrophone } from 'react-icons/hi'; | ||
| import { MdKeyboardArrowLeft } from 'react-icons/md'; | ||
|
|
||
| const Navbar = () => ( |
There was a problem hiding this comment.
- I think it would be better if you make your navbar looks like the one more in the given design. You can take a look at the below original design and compare it with yours and fix it 👇
There was a problem hiding this comment.
Hi Lynette,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Fix overflow
Merge pull request #9 from iLynette/development
Hello Reviewer 👋🏾 ,
In this project I implemented the following;
Select the Makeup API.
Built files structure for my React app.
Prepared routes and navigation in my app.
Make sure that a user can display a list of items and filter them. Data should come from the API.
Created the tests for the application.
Styled my components to match the design provided.
Deployed the project and tested for final details.
Recorded a video for my project.
Created a good README.
Thank you for your review☺️