Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /setup endpoint #189

Closed
iMicknl opened this issue Sep 26, 2021 · 2 comments · Fixed by #223
Closed

Add /setup endpoint #189

iMicknl opened this issue Sep 26, 2021 · 2 comments · Fixed by #223

Comments

@iMicknl
Copy link
Owner

iMicknl commented Sep 26, 2021

We currently don't use this in ha-tahoma, but it makes sense to have this endpoint in our API client as well. I use this a lot to retrieve full setup details of users I am helping.

@iMicknl
Copy link
Owner Author

iMicknl commented Sep 26, 2021

@tetienne you are good in testing I saw lately. I have about 5 setup.jsons from different users (tahoma, hi kumo, nexity, cozy touch). Can we add them to the repo and do automatic testing? (I will obfuscate all information).

Eventually we could even use these setup.jsons to do end to end testing with our HA component.

@tetienne
Copy link
Collaborator

If this endpoint exists we can indeed add it.
About testing, you can have a look of I've already done and just add a parameterized layee above to run your test with various json.

@iMicknl iMicknl linked a pull request Oct 31, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants