Feature Request: Snackbar to start Orbot

[SkewedZeppelin]

Commit 875810e added options to start or install Orbot if needed in EditAccountActivity, a snackbar in ConversationFragment similar to the disabled account one would be very helpful/informative.

I tried giving it a go but made a mess with the listener callbacks and context to launch intents.
Here is my attempt: https://gist.github.com/SkewedZeppelin/109a3e35c3008b78988d08cb03f85993

[licaon-kter]

What's the usecase exactly? When do you need it?

[SkewedZeppelin]

@licaon-kter
Convenience for when Orbot stops running for whatever reason.

It would also bring in line with the current UX that exists:

• Account Screen: Enable / Start Orbot
• Conversation activity: "You have disabled this account, Enable" / [this request]

[licaon-kter]

Did you test the current behaviour? What happens when you touch the retry button on "some accounts can't connect" notification?

[SkewedZeppelin]

@licaon-kter that notification takes a long while to appear. And clicking "Try again", doesn't actually start Orbot.

Maybe that should be a bug report on its own, using Orbot 16.0.5-RC-1-tor-0.3.4.9 with background starts allowed. I think it might be because Conversations tries to launch the Orbot activity instead of just sending a broadcast.

[licaon-kter]

Well the launch should be even better, depending on why it stopped (eg. OEM ROM aggresively suspending the app and cutting connection to save battery), a simple broadcast might be useless.

Eg. Testing it I saw Orbot running, no connection, launch Orbot, look in the log... It got "already running ignoring start request" (or whatever that says) but it was not doing anything at all, so broadcasts were useless.

But I do agree that the broadcast is the cleaner method, not popup orbot, but in the real world things are not clear cut.

[eveofdestruction]

How is framing this as a Conversations feature better than using Tasker or similar as the watchdog?

Convenience for when Orbot stops running for whatever reason.

@ SkewedZeppelin

[licaon-kter]

I'm not sure this issue should be open anymore.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.