Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immersive Portals is incompatible with Sodium #254

Closed
Neubulae opened this issue May 11, 2020 · 6 comments
Closed

Immersive Portals is incompatible with Sodium #254

Neubulae opened this issue May 11, 2020 · 6 comments

Comments

@Neubulae
Copy link

https://github.com/jellysquid3/sodium-fabric
crash-2020-05-12_00.36.07-client.txt

@LoganDark
Copy link
Collaborator

Highlight:

Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @At("INVOKE") on net/minecraft/class_761::redirectGetTranslucent with priority 1000 cannot inject into net/minecraft/class_761::method_3251(Lnet/minecraft/class_1921;Lnet/minecraft/class_4587;DDD)V merged by me.jellysquid.mods.sodium.mixin.chunk_rendering.MixinWorldRenderer with priority 1000 [PREINJECT Applicator Phase -> immersive_portals.mixins_client.json:MixinWorldRenderer -> Prepare Injections -> -> redirect$dle000$redirectGetTranslucent()Lnet/minecraft/class_1921; -> Prepare]

@qouteall
Copy link
Member

Sodium's injection is more invasive than OptiFine, so making it compatible is non-trivial work.

@qouteall
Copy link
Member

And I will start investigating it after sodium's first release

@Jarfeh
Copy link

Jarfeh commented Jan 2, 2021

I noticed that you've since closed the pull request under sodium for compatibility. Has the compatibility issue been resolved?

@qouteall
Copy link
Member

qouteall commented Jan 2, 2021

@Jarfeh I added another pr. Because sodium switched development branch for 2 times.

@Jarfeh
Copy link

Jarfeh commented Jan 2, 2021

Ah, I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants