Upgrading to React Native 0.16

[iSimar]

@ivanph I'm currently trying to upgrade the app with react native 0.16 under the react-native-0_16 branch, could you confirm if everything is fine with android

[ivanph]

Hi @iSimar

The following folders are missing

android/app/src/main/res/drawable-hdpi/
android/app/src/main/res/drawable-mdpi/
android/app/src/main/res/drawable-xhdpi/
android/app/src/main/res/drawable-xxhdpi/
android/app/src/main/res/drawable-xxxhdpi/

They contain the navigation icon for the toolbar in different sizes.
Also package.json is missing the react-native-webintent module that is used to open the posts links.
Maybe you could create a PR and we can discuss the changes there.
Cheers.

[iSimar]

I tried upgrading react native to 0.16 with package.json & npm install but it broke a bunch of stuff, so I had to react-native init a new project and copy over the stuff manually.

I have added the missing stuff you mentioned above just now. I did not add react-native-webintent because I think it would be better to upgrade to IntentAndroid. See commit 6e52dcb

[ivanph]

I created a branch with the upgrade to version 0.16 and replaced the webintent module with IntentAndroid.
It might be easier if we merge that branch first and then you could add your changes on top.

[amilajack]

I'm getting this error when I checked out the branch and installed dependencies

[iSimar]

@amilajack I don't seem to be getting that error after cloning/checking-out the branch. Try pulling the new commits see if you're getting the same error.

[johntom]

Hi,
Tried Android on win10 running node v4.2.1 with npm 3.5.2

1. If I just try a git clone with repo iSimar or ivanph I cant get npm install to run
2. I created a sep directory with react-native init HackerNewsReactNative
3. I then copied package.json, index.android.js and app dir but get requiring unkown module "react-native-webintent"
   John

[iSimar]

@johntom I'm unaware of this issue, I will try to look into it.

@ivanph I'm actually recoding most of the app, I don't think that would be necessary

[iSimar]

The master has been updated.