Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Notifications not longer stick #1872

Closed
2 tasks done
caseydtrail opened this issue Nov 16, 2023 · 8 comments
Closed
2 tasks done

Sticky Notifications not longer stick #1872

caseydtrail opened this issue Nov 16, 2023 · 8 comments

Comments

@caseydtrail
Copy link

Pre-submission checklist

  • I am submitting a bug report, not a feature request.
  • I have searched for similar issues, but did not find any matches.

Description

The app setting allows for "sticky notifications." Previously, when those notifications are enabled I have to answer the question in the notification (or by marking today's value) before the notification could be dismissed. Now, the notification can be dismissed simply by swiping.

Steps to reproduce

  1. Go to settings
  2. Scroll down to the "Reminders" section
  3. Enable "Make notifications sticky"
  4. Wait for a reminder notification.
  5. Swipe down to view the notification.
  6. Swipe right/left to clear the notification WITHOUT answering the question or marking the habit in the app.

System information

  • Phone: Google Pixel 6a
  • Phone Operating System: Android 14
  • App version: 2.1.3
@heywhitneyragan
Copy link

Experiencing the same thing.

System information
Phone: Google Pixel 8Pro
Phone Operating System: Android 14
App version: 2.1.3

@jayb-g
Copy link

jayb-g commented Nov 25, 2023

Having same issue on Android 14

AFAIR it used to stick until a month or so ago. Something changed, maybe a new app update or OS update made it non-sticky. Recent update to Android 14 might be the cause.

This project probably uses ongoing notifications to make them sticky. And according to this, they are now swipable since Android 14. Don't know if there would be a workaround or a feature update is required to reimplement this for A14.

@iSoron
Copy link
Owner

iSoron commented Nov 25, 2023

Thanks for letting us know, @caseydtrail. For some inexplicable reason, non-dismissible notifications are now dismissible in Android 14. There is unfortunately nothing we can do to restore the previous behavior. The question now is, should we remove this feature altogether, or are the new somewhat-non-dismissible notifications still useful to anyone?

@jayb-g
Copy link

jayb-g commented Nov 25, 2023

@iSoron it is definitely useful to have them stick. Prevents accidental discard and also makes it mandatory to select an option to discard so no data points are skipped.

@heywhitneyragan
Copy link

@iSoron - I'm really missing the sticky option as well. I've accidentally swiped them away several times. If the ability to make them non-dismissable isn't returning, I don't know that I see a reason to keep the feature as is since it doesn't do what it says anymore. I know it's not your fault at all, just a bummer that this happened with Android 14.

@iSoron
Copy link
Owner

iSoron commented Nov 25, 2023

Thanks for the feedback, everyone. We implemented a workaround in f0ce05e to keep sticky notifications non-dismissible in Android 14+. If sticky notifications are enabled and you accidentally dismiss them, Loop will automatically re-show them. See video below. This feature will be available in Loop 2.2. When it becomes available to you, please test it out and let us know if you have any issues.

Screen_recording_20231125_154253.webm

@iSoron iSoron closed this as completed Nov 25, 2023
@jayb-g
Copy link

jayb-g commented Dec 1, 2023

I see that system notifications like OS update are still sticky on Android 14. Is it something that only system apps can do since A14?

@jayb-g
Copy link

jayb-g commented May 8, 2024

@iSoron is the current fix still incomplete?

In my P7, it works as expected, ie notification shows up again after discarding.

Although on P8, notification is still discardable(and doesn't automatically show up again)

I have both latest, AOSP14 and the app on both devices. Sticky setting is enabled in both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants