Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StructuralPhysical schema v1.0.0 missing bis:PhysicalType subclasses #67

Open
diegoalexdiaz opened this issue Mar 31, 2022 · 3 comments · May be fixed by #106
Open

StructuralPhysical schema v1.0.0 missing bis:PhysicalType subclasses #67

diegoalexdiaz opened this issue Mar 31, 2022 · 3 comments · May be fixed by #106
Assignees

Comments

@diegoalexdiaz
Copy link
Contributor

Every concrete bis:PhysicalElement class in the StructuralPhysical schema shall have a corresponding PhysicalType subclass. E.g. Column --> ColumnType, Beam --> BeamType, etc.

@NabilSleiman
Copy link

We have the extruded member which can be a column or a beam, should we deprecate that in favor of more specific members?

@diegoalexdiaz
Copy link
Contributor Author

The StructuralPhysical schema (both versions 1.0.0 and 1.1.0) have several concrete-physical-classes (i.e. classes that can be instantiated). That schema needs to provide corresponding PhysicalType-classes so connectors/iModel-writers can setup the expected PhysicalElement->is of->PhysicalType pattern in BIS.

@diegoalexdiaz
Copy link
Contributor Author

Per BWG meeting: Add StructuralAssemblyType and StructuralAccessoryType to the types already included in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants