-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComboBox dropdown sizing problem when using sublabels #2008
Comments
Can you please provide a repro? This bug report is not actionable in its current state. |
To reproduce, open following iModel in pineapple Create a new data visualization. Click on the Property combobox and scroll to the end. There is a blank area and the scroll region extends too far. |
@mayank99 fyi this is using @itwin/itwinui-react@2.12.26 |
While that link is not a proper repro (and you probably shouldn't share it publicly?), I was able to inspect it and found that you're using Our current plan is to refactor the virtual scroll logic in the coming months, which will likely fix this issue but only in v3. Since you're on v2, which is expected to reach end-of-life very soon, you would not benefit from the refactor. And since this issue is also a duplicate of #1107 (which has a proper repro), I will close it and we can use the other one for tracking. |
Describe the bug (current behavior)
When sublabels are not all defined, the size of the dropdown container and scrolling region is not correct and there is a blank area at the bottom. Using a workaround for now to provide a single space string instead of undefined or empty string.
Expected Behavior
No response
Link to minimal repro
https://qa-review.itwin.bentley.com/context/8b3d0653-02b5-4a76-832e-7c16ed50ff21/imodel/b9bf7a2d-bf2e-4d3f-b127-90c8029a855e?changesetid=308791f67a9c5ece81a1c792b3ab3cf1ab584b47&it3mode
Steps To Reproduce
Create a new data visualization. Click on the Property combobox and scroll to the end. There is a blank area and the scroll region extends too far.
Anything else?
No response
The text was updated successfully, but these errors were encountered: