Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: Input size prop overrides native size attribute #973

Closed
Tracked by #1222
FlyersPh9 opened this issue Jan 9, 2023 · 0 comments · Fixed by #1419
Closed
Tracked by #1222

v3: Input size prop overrides native size attribute #973

FlyersPh9 opened this issue Jan 9, 2023 · 0 comments · Fixed by #1419
Assignees
@adamhock
Labels
bug Something isn't working major Requires breaking changes react Needs change in react package
Milestone
React 3.0

Comments

@FlyersPh9
Copy link
Collaborator

native input has size prop, which we drop out. Need to rename our prop and return the native prop.
@FlyersPh9 FlyersPh9 added this to the React 3.0 milestone Jan 9, 2023
@FlyersPh9 FlyersPh9 added enhancement New feature or request major Requires breaking changes react Needs change in react package labels Jan 9, 2023
@mayank99 mayank99 changed the title Input has custom size prop Input size prop overrides native size attribute Jan 9, 2023
@mayank99 mayank99 added bug Something isn't working and removed enhancement New feature or request labels Jan 9, 2023
@gretanausedaite gretanausedaite mentioned this issue Apr 20, 2023
Closed
24 tasks
@mayank99 mayank99 changed the title Input size prop overrides native size attribute v3: Input size prop overrides native size attribute May 2, 2023
@adamhock adamhock mentioned this issue Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamhock adamhock

Labels
bug Something isn't working major Requires breaking changes react Needs change in react package
Projects
None yet
Milestone
React 3.0
Development

Successfully merging a pull request may close this issue.

fix(Input): Added htmlSize prop to set native size attribute iTwin/iTwinUI
3 participants
@FlyersPh9 @mayank99 @adamhock