Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3: Rename MenuItem props (badge → endIcon and icon → startIcon) #974

Closed
Tracked by #1222
FlyersPh9 opened this issue Jan 9, 2023 · 4 comments · Fixed by #1295
Closed
Tracked by #1222

v3: Rename MenuItem props (badge → endIcon and icon → startIcon) #974

FlyersPh9 opened this issue Jan 9, 2023 · 4 comments · Fixed by #1295
Labels
major Requires breaking changes react Needs change in react package
Milestone
React 3.0

Comments

@FlyersPh9
Copy link
Collaborator

FlyersPh9 commented Jan 9, 2023 •
edited

Rename badge to endIcon.
Rename icon to startIcon.
@FlyersPh9 FlyersPh9 added major Requires breaking changes react Needs change in react package labels Jan 9, 2023
@FlyersPh9 FlyersPh9 added this to the React 3.0 milestone Jan 9, 2023
@ibharatsaini
Copy link

Hi,
Should all the badge and icon be changed on every component they are being passed to? or just the MenuItem component?

@mayank99
Copy link
Contributor

@ibharatsaini I'm not sure I understand your question. This is not done yet, it's a planned item for our next major release (itwinui-react v3). And I believe MenuItem is the only component where these ambiguous names exist.

@ibharatsaini
Copy link

Can you assign this to me?

@mayank99
Copy link
Contributor

@ibharatsaini We haven't started working on v3.0, so it's a bit early to work on this item. However, if you are still interested in contributing, we do have a few other "good first issue"s that you could pick from.

@gretanausedaite gretanausedaite mentioned this issue Apr 20, 2023
Closed
24 tasks
@mayank99 mayank99 changed the title MenuItem props: badge → endIcon and icon → startIcon. v3: Rename MenuItem props (badge → endIcon and icon → startIcon) May 2, 2023
@gretanausedaite gretanausedaite linked a pull request May 24, 2023 that will close this issue
v3: Menu is using ListItem #1295
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major Requires breaking changes react Needs change in react package
Projects
None yet
Milestone
React 3.0
Development

Successfully merging a pull request may close this issue.

v3: Menu is using ListItem iTwin/iTwinUI
3 participants
@FlyersPh9 @mayank99 @ibharatsaini