Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a git hook to invoke sort-package-json on staged package.json changes #59

Open
MichaelBelousov opened this issue Oct 14, 2020 · 0 comments
Open

add a git hook to invoke sort-package-json on staged package.json changes #59

MichaelBelousov opened this issue Oct 14, 2020 · 0 comments

Comments

@MichaelBelousov
Copy link
Contributor

had a build fail because package.json was unsorted, which rush doesn't support sorting of. We should just invoke the sort-package-json script from npm on lint-staged as a pre-commit hook, so it never bothers us.
@aruniverse aruniverse linked a pull request Dec 22, 2020 that will close this issue
lint package.json to prevent ci failures #88
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lint package.json to prevent ci failures iTwin/viewer-components-react
1 participant
@MichaelBelousov