Highlight the text in ValueField when shouldResetOnInsertion is enabled #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achernenko-pp
force-pushed
the
highlight-when-resetoninsertion-is-enabled
branch
5 times, most recently
from
980fe48
to
7824c81
Compare
achernenko-pp
force-pushed
the
highlight-when-resetoninsertion-is-enabled
branch
from
7824c81
to
15f94d8
Compare
enhorn
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
shouldResetOnInsertionis a flag that was recently added toValueField. If enabled, the field value will be cleared before inserting text (see #152 for details).What has been done?
This PR adds a new behavior: the field value is marked with
style.textHighlightColorwhenshouldResetOnInsertionis enabled. This should make it clear to the user that the current value will be replaced by the input (as opposed to being appended).style.textHighlightColoris optional andnilby default, so for the existing users ofValueFieldnothing will change.Demo