-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS0102: open a .osim file and load its elements to the navigator. #2
Comments
How is the progress so far? are there some difficulties? It would be nice if we can close this milestone before the end of this month. Some tips:
|
@idhamari Hi !
|
Looks very good, well done! If needed, I will provide a feedback after I test it. For now, please merge the commit, close this issue and proceed to the next task. |
Ok, I just checked the files. Do we really need all these files? Since they are all doing the same things, can't we just create only one file for this e.g. vsNavigator.h vsNavigator.cpp Anything related to the navigator we add to this file. |
another comment: please add vs to all classes files and classes names and use standard naming ( capitalize first letters of the words) e.g.:
Also in the navigator use consistent naming for the nodes e.g.
I would use one word e.g. Bodies, Forces, Markers..etc. Please also pay attention to the first letters, it should be capitalized e.g. Offset instead of offset and ContactGeomtries instead of contactgeometryset |
one more comment, please use a cross-platform code e.g. using cmake variables e.g. in CMakeLists.txt use
instead of
the second one may work in Windows but in Linux it produces a configuration error |
I just built the source and tried to run it. It seems the open model action is not working. Am I missing something? |
|
@idhamari |
Thanks for the info. I still think it is better to use one file with a flexible code as most of the node actions are the same. We can discuss this more in a skype meeting if you like. The error was related to cmake, it is already fixed using CMAKE_CURRENT_SOURCE_DIR. The current problem is I can not open a model. When I click on open model nothing happens. Did you implement the action? |
I removed the contents of the build folder then rebuild it again. The gui now working as expected and the model is loaded. |
The text was updated successfully, but these errors were encountered: