Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend - Add form for natural language query #85

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Frontend - Add form for natural language query #85

wants to merge 2 commits into from

Conversation

NoB0
Copy link
Collaborator

@NoB0 NoB0 commented Jan 29, 2024 •
edited

Create a component for form with single text input. Use this component in the home view.

What's changed

  • Add QueryForm that has a single text field and a submit button. The component take as properties a function to handle the submission of the form and an error message.
  • Add Layout to navigate between the different views
  • Update APIHandler to display the correct view
  • Formatted UserContext

Left a TODO to handle the response of the server.
Part of #62

@NoB0 NoB0 requested a review from WerLaj as a code owner January 29, 2024 10:19
@NoB0 NoB0 requested a review from galuscakova January 29, 2024 10:20
@github-actions GitHub Actions
Copy link

Unit Test Results

31 tests   31 ✔️  2s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 17e0c7d.

@github-actions GitHub Actions
Copy link

Coverage Report •
FileStmtsMissCoverMissing
TOTAL5692694% 
report-only-changed-files is enabled. No files were changed during this commit :)

@github-actions GitHub Actions
Copy link

Current Branch Main Branch
Coverage Badge Coverage Badge

WerLaj
WerLaj approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoB0 NoB0 linked an issue Feb 6, 2024 that may be closed by this pull request
NL query view frontend #62
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WerLaj WerLaj WerLaj approved these changes

@galuscakova galuscakova Awaiting requested review from galuscakova

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NL query view frontend
2 participants
@NoB0 @WerLaj