Outside-if-not working with version 2.2.1, not anymore with newer versions

[rbnvrw]

When I update the plugin to a version > 2.2.1, the outside-if-not attribute stopped working. Small code snippet:

<div  data-click-outside="deselectFormElement()" 
data-outside-if-not="editor__sidebar,option__button">

Downgrading to version 2.2.1 fixes the issue. Could you please fix it in a new version?

Please consider adding unit tests/e2e tests to prevent regressions. Other than that, I really appreciate your plugin!

[IamAdamJowett]

@rbnvrw I am putting tests in at the moment, but manual tests in the example app within this repo is not showing the same behavior, do you have a jsfiddle or the like for me to see the behavior?

[rbnvrw]

That is great. I do not have the time to create a jsfiddle now, but I will make one for you tomorrow.

[elliottregan]

I can second this. I haven't had time to really debug it, but I had to roll back to 2.2.1 to get it to work again.

[IamAdamJowett]

@rbnvrw and @elliottregan a quick question, are by chance either of you on a touchscreen laptop or PC? (not a tablet or mobile)

[IamAdamJowett]

@rbnvrw @elliottregan Check out release 2.5.0 and let me know if this fixes the issues you are finding.

[elliottregan]

Seems to be working again! Thanks!

I was on a regular Mac, no touchscreen.

[elliottregan]

@IamAdamJowett This bug is back in the latest release. Same thing, no touch screen.

Also in 2.6.2.

[rbnvrw]

Here also no touchscreen.

[IamAdamJowett]

@elliottregan I assume you mean 2.6.2, I will see what has changed that may have brought this back

[elliottregan]

Yup. Fixed my comment.

[IamAdamJowett]

@elliottregan fixes should be in the latest version 2.8.2 that covers this off. 5c64f22