You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #205 I noticed that we are (almost) never using the lookup property that using a dictionary Dict[str, Code] over a list of Code objects gives us.
If there are no applications for the lookup I would suggest changing it so that CodeList contains an actual list of codes and not a dictionary.
Not a real priority though just something I noticed and might confuse contributors.
The text was updated successfully, but these errors were encountered:
It may not be relevant for the automated processing, but when actually working with the DataStructureDefinition, I do find it helpful to look at the attributes of a variable from a Jupyter notebook environment like
DataStructureDefinition.variable["Final Energy"]
So I would keep a way to access a Code in this way.
While working on #205 I noticed that we are (almost) never using the lookup property that using a dictionary
Dict[str, Code]
over a list of Code objects gives us.If there are no applications for the lookup I would suggest changing it so that
CodeList
contains an actual list of codes and not a dictionary.Not a real priority though just something I noticed and might confuse contributors.
The text was updated successfully, but these errors were encountered: