Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate "countries" attribute against ISO3 codes #224

Closed
danielhuppmann opened this issue Feb 9, 2023 · 2 comments
Closed

Validate "countries" attribute against ISO3 codes #224

danielhuppmann opened this issue Feb 9, 2023 · 2 comments
Assignees
@phackstock @GretchenSchowalter
Labels
enhancement New feature or request

Comments

@danielhuppmann
Copy link
Member

In iiasa/eu-climate-advisory-board-workflow#32 (and similar pull requests), we added an attribute "countries" to the region definitions. It would be useful to add a validation that these are valid ISO3 codes.

Also, this might require some fidgeting translating from a human-readable list to a proper Python list.
@danielhuppmann
Copy link
Member Author

Per suggestion by @byersiiasa, fyi @phackstock

@phackstock phackstock added the enhancement New feature or request label Mar 7, 2023
@GretchenSchowalter GretchenSchowalter mentioned this issue May 2, 2023
Merged
@phackstock
Copy link
Contributor

Addressed in #240, thanks @GretchenSchowalter 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phackstock phackstock

@GretchenSchowalter GretchenSchowalter

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielhuppmann @phackstock @GretchenSchowalter