Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly tests failing because of legacy definitions update #348

Closed
phackstock opened this issue May 28, 2024 · 0 comments · Fixed by #349
Closed

Nightly tests failing because of legacy definitions update #348

phackstock opened this issue May 28, 2024 · 0 comments · Fixed by #349
Assignees

Comments

@phackstock
Copy link
Contributor

Since the update IAMconsortium/legacy-definitions@bad8c0c, the test that pulls from common- and legacy-definitions has been failing. The reason for that is that it tested for the presence of the variable Employment in the legacy-definitions. With the above commit it was moved.
To me the most obvious fix is to use the already existing pin feature for common- and legacy-definitions rather than adjust the variables we test for.

FYI @danielhuppmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant