Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #211

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Linting #211

merged 4 commits into from
Sep 18, 2019

Conversation

iamdefinitelyahuman
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman commented Sep 17, 2019

  • Added additional annotations, mypy checks now passing across entire project.
  • Increased black max line length to 100, replaced flake8 lint checks with black.
  • Applied isort formatting, added to lint build
  • Separated slower tests into their own builds (added --evm-tests and --mix-tests flags)

Closes #210

@ghost
Copy link

ghost commented Sep 17, 2019

Thanks for getting all the typing imports in alphabetical order. I meant to go back and do that. Does black or any other tool do that automatically or did you adjust manually?

@iamdefinitelyahuman
Copy link
Member Author

@crawfordleeds it's isort.. wonderful tool :)

@iamdefinitelyahuman iamdefinitelyahuman merged commit 164ef87 into master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to linting
1 participant