Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check web3.eth.accounts when calling Accounts.at #551

Merged
merged 1 commit into from May 24, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Check web3.eth.accounts when accessing an account via Accounts.at - useful if a new account was added from e.g. a hardware wallet being unlocked.

How to verify it

Run tests.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #551 into master will decrease coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   88.19%   88.15%   -0.05%     
==========================================
  Files          56       56              
  Lines        6304     6307       +3     
  Branches     1392     1394       +2     
==========================================
  Hits         5560     5560              
- Misses        514      516       +2     
- Partials      230      231       +1     
Impacted Files Coverage Δ
brownie/network/account.py 92.95% <57.14%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408a973...9cf4bc4. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 70cdd4f into master May 24, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-accounts-at branch May 24, 2020 18:30
@BrokedTV
Copy link

When i add an account with
accounts.at('0x5ba30f12022c0b29acee4faed0666dcf6524f424', force=True)
on a development network, I can see it added to "accounts"
but if i call web3.eth.accounts it's not added.
how could i sync them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants