Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments not following standard integration #10

Closed
jeremenichelli opened this issue Jun 11, 2015 · 1 comment
Closed

Arguments not following standard integration #10

jeremenichelli opened this issue Jun 11, 2015 · 1 comment

Comments

@jeremenichelli
Copy link
Collaborator

I've noticed that Firefox is the only browser which has this behavior enable by default. The thing is that inside the window.scroll declaration it expects an object while it still gives supports for the old two number arguments.

window.scroll({
    top: 120,
    left: 20,
   behavior: 'smooth'
});

Since Firefox is expecting this, the script will return because it finds that smoothBehavioris implemented and never work.

If you are ok with this, I can create a pull request with all the necessary changes to adapt your script to this type of call which I guess is the standard one instead of the actual that doesn't have an options object.

@tiye
Copy link

tiye commented Jun 26, 2015

So what's next... I found Firefox odd too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants