Added support for parsing timestamptz as UTCDateTime #263

rofinn · 2023-02-18T05:00:37Z

github-actions · 2023-02-18T05:02:24Z

src/parsing.jl

 )
+
+function _pqparse(::Type{T}, str::AbstractString) where T<:Union{UTCDateTime, ZonedDateTime}


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

function _pqparse(::Type{T}, str::AbstractString) where T<:Union{UTCDateTime, ZonedDateTime}

function _pqparse(

::Type{T}, str::AbstractString

) where {T<:Union{UTCDateTime,ZonedDateTime}}

test/runtests.jl

+                                    result = execute(
+                                        conn,
+                                        "SELECT $test_str;";
+                                        binary_format=binary_format,
+                                        type_map=Dict(:timestamptz => UTCDateTime),
+                                    )


test/runtests.jl

+                                    parsed = func(LibPQ.PQValue{oid}(result, 1, 1))
+                                    @test isequal(parsed, data)
+                                    @test typeof(parsed) == UTCDateTime
+                                    parsed_no_oid = func(LibPQ.PQValue(result, 1, 1))
+                                    @test isequal(parsed_no_oid, data)
+                                    @test typeof(parsed_no_oid) == UTCDateTime


github-actions · 2023-02-18T05:02:25Z

test/runtests.jl

+                            end
                        end


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

end

end

rofinn · 2023-02-21T22:12:17Z

FWIW, the error codes CI check is also failing on nightly and the formatting suggestions seem pretty borked. Should probably just fix them in separate MRs?

morris25

Looks fine to me. The formatter is needlessly strict sometimes

rofinn · 2023-02-21T22:45:43Z

Thanks, I'm just gonna give @iamed2 a chance to comment before merging and tagging.

src/parsing.jl

test/runtests.jl

src/parsing.jl

rofinn · 2023-02-23T00:09:30Z

Comments addressed in the MR above.

Addressing post-merge comments on #263

Added support for parsing timestamptz as UTCDateTime.

2fc84d8

github-actions bot reviewed Feb 18, 2023

View reviewed changes

morris25 approved these changes Feb 21, 2023

View reviewed changes