Add Support for DBInterface #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Davies <iamed2@gmail.com>
Co-authored-by: Eric Davies <iamed2@gmail.com>
|
Happy to merge! Thanks for sticking with it. |
|
Thanks for picking this up @TheCedarPrince - I appreciate it! |
|
Thank you all!!!! This is amazing!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes @chris-b1's initial PR they had drafted in #271; it closes #271.
I am opening this new PR that rebases against master such that this feature can be merged after the other PR hasn't had any recent activity from the original creator. Credit and a huge thanks for the majority of this PR goes to @chris-b1 and @xitology for initial implementation help.
@iamed2 , this PR has been rebased against master and is ready to merge per your last comment. Are you comfortable merging this? If so, feel free to hit the merge button when ready! 💯