Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Exception types #11

Closed
iamed2 opened this issue Nov 23, 2017 · 2 comments · Fixed by #113
Closed

Introduce Exception types #11

iamed2 opened this issue Nov 23, 2017 · 2 comments · Fixed by #113
Milestone

Comments

@iamed2
Copy link
Owner

iamed2 commented Nov 23, 2017

All the error calls could be different exception types. In addition, exception types representing PostgreSQL errors should contain a reference to the connection, to enable follow-up actions (including printing more verbose errors).

@iamed2 iamed2 added this to the v1.0.0 milestone Nov 23, 2017
@oxinabox
Copy link

oxinabox commented May 15, 2019

This would be really nice.
It would make it easier to retry on

ErrorException("server closed the connection unexpectedly
    This probably means the server terminated abnormally
    before or while processing the request.\n"),
    Any[(error at loggers.jl:429, 1), (#handle_new_connection#8 at LibPQ.jl:155, 1), 

I guess it means regexing the error messages?

@iamed2
Copy link
Owner Author

iamed2 commented Jul 16, 2019

In #113 this would be LibPQ.ConnectionFailure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants