Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issue in model.py #20

Open
guangyaodou opened this issue Apr 15, 2024 · 1 comment
Open

Some issue in model.py #20

guangyaodou opened this issue Apr 15, 2024 · 1 comment

Comments

@guangyaodou
Copy link

Hi,

I found a strange line here in your code - https://github.com/iamgroot42/mimir/blob/main/mimir/models.py#L183

Is this a bug or is there any other particular reason? It is currently overriding what I am specifying in the config file.

Thanks.

@iamgroot42
Copy link
Owner

Hey @guangyaodou - this was a deliberate inclusion at the time of code development, since Llama is pretty big and we didn't want scripts to run into OOM issues with the main and auxiliary models being on the same device. That being said, it is probably best to not override the config as you said. I can handle this change in the next version, but would also be great if you want to submit a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants