Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to upload image #64

Closed
bjorns opened this issue Feb 7, 2023 · 3 comments
Closed

Failed to upload image #64

bjorns opened this issue Feb 7, 2023 · 3 comments

Comments

@bjorns
Copy link
Contributor

bjorns commented Feb 7, 2023

I have an image notation in my markdown file

![The credential set form](images/auth-token-form.png)

I see this error when the file is uploaded as part of a folder with the new relative links flag enabled:

ERROR: Session.request() got an unexpected keyword argument 'format'    

I did some very brief digging and it looks like the parameters in api.py may not have been updated to match requests. I see on line 230:

                data={"comment": message} if message else None,
                format=(None, "json"),

and I'm thinking it should be something like:

                json={"comment": message} if message else None,

That's just a guess though.

@bjorns
Copy link
Contributor Author

bjorns commented Feb 7, 2023

Also: Psyched for the 2.0 update, thanks!

@iamjackg
Copy link
Owner

iamjackg commented Feb 7, 2023

Ugh, you're absolutely right. I need to add tests for the attachment functions. Sorry about this! I'll fix it right away.

@iamjackg
Copy link
Owner

iamjackg commented Feb 7, 2023

Fixed in v2.0.1 :)

@iamjackg iamjackg closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants