Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict parsing support with UTC plugin #1027

Closed
vbatoufflet opened this issue Aug 26, 2020 · 5 comments · Fixed by #1443
Closed

Strict parsing support with UTC plugin #1027

vbatoufflet opened this issue Aug 26, 2020 · 5 comments · Fixed by #1443
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@vbatoufflet
Copy link

Hi,

Looking at the dayjs function signature and at the String + Format documentation there is a strict parsing mode using a 3rd (or 4th when using locale) boolean flag:

dayjs(date?: dayjs.ConfigType, format?: dayjs.OptionType, strict?: boolean)

Looking at the corresponding UTC plugin, it doesn't seem to have such option available:

dayjs.utc(config?: dayjs.ConfigType, format?: string)

Did I miss something obvious in the documentation?

If not, is it something that's worth be supported in the future?

Thanks!

@iamkun iamkun added the enhancement New feature or request label Aug 31, 2020
@homoky
Copy link

homoky commented Oct 9, 2020

That would be a great upgrade. We use only utc() version so this would simplify our codebase.

@iamkun
Copy link
Owner

iamkun commented Oct 13, 2020

Seems UTC plugin supports strict parsing already, all we have to do is to update the docs and the ts type file.

@LucasHFS
Copy link
Contributor

LucasHFS commented Apr 7, 2021

I'm working on this on #1443 , Let me know if something else is needed.

@iamkun
Copy link
Owner

iamkun commented Jul 6, 2021

🎉 This issue has been resolved in version 1.10.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Jul 6, 2021
@0xsven
Copy link

0xsven commented Nov 17, 2021

This issue seems to be back in 1.10.7
@iamkun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants