Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breton language not using mutation #1104

Closed
jbleduigou opened this issue Oct 1, 2020 · 5 comments
Closed

Breton language not using mutation #1104

jbleduigou opened this issue Oct 1, 2020 · 5 comments

Comments

@jbleduigou
Copy link
Contributor

Describe the bug
Breton language has some mutations.
See this page for more details.
This logic is in place in Moment.js but is currently missing in dayjs.

Expected behavior
See for instance the test result for this:

Summary of all failing tests
 FAIL  test/locale/br.test.js
  ● RelativeTime: Time from X

    expect(received).toBe(expected) // Object.is equality
    
    Expected value to be:
      "2 vloaz ʼzo"
    Received:
      "2 bloaz ʼzo"

      44 |     moment.locale('br')
      45 |     expect(dayjs().from(dayjs().add(t[0], t[1])))
    > 46 |       .toBe(moment().from(moment().add(t[0], t[1])))
      47 |     expect(dayjs().from(dayjs().add(t[0], t[1]), true))
      48 |       .toBe(moment().from(moment().add(t[0], t[1]), true))
      49 |   })
      
      at forEach (test/locale/br.test.js:46:8)
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/locale/br.test.js:42:5)

Information

  • Day.js Version : dev branch
  • Running jest in console on MacOs
@jbleduigou
Copy link
Contributor Author

See commented line in br.test.js, line 39

@iamkun
Copy link
Owner

iamkun commented Oct 2, 2020

I'm sorry that I did not get what's the mutation error is?

@jbleduigou
Copy link
Contributor Author

Breton language has a paradigm similar to the German Declension.
What happens is that the first letter of a word might change depending on the previous word in the sentence.

For instance the word "year" is "bloaz" in breton.
"1 year" becomes "1 bloaz", no mutation here.
However "2 years" becomes "2 vloaz", 'b' is mutated to 'v'.

@jbleduigou
Copy link
Contributor Author

Implemented within #1103

@iamkun
Copy link
Owner

iamkun commented Oct 13, 2020

fixed in #1103

@iamkun iamkun closed this as completed Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants