Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firstDayOfWeek for Maldivian (dv) is 7 instead of 0 through 6 #1535

Open
TaylorWebb opened this issue Jun 16, 2021 · 0 comments
Open

firstDayOfWeek for Maldivian (dv) is 7 instead of 0 through 6 #1535

TaylorWebb opened this issue Jun 16, 2021 · 0 comments

Comments

@TaylorWebb
Copy link

TaylorWebb commented Jun 16, 2021

Describe the bug
This is through the LocaleDate extension. The firstDayOfWeek for Maldivian (dv) seems to be incorrect. More specifically, it is 7, but it should be a value from 0 to 6, inclusive. It is because weekStart is set to 7 https://github.com/iamkun/dayjs/blob/dev/src/locale/dv.js

Expected behavior
I believe the first day of the week in the Maldives is Sunday, so it should be the default value of 0 for Sunday.

Information

  • Day.js Version: We are using 1.10.4 but looks like it's also probably in 1.10.5.
  • OS: N/A
  • Browser: N/A
  • Time zone: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant