Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM modules aren't registered in package.json #2025

Open
fabis94 opened this issue Aug 12, 2022 · 1 comment
Open

ESM modules aren't registered in package.json #2025

fabis94 opened this issue Aug 12, 2022 · 1 comment

Comments

@fabis94
Copy link

fabis94 commented Aug 12, 2022

Describe the bug
Even though this package comes with an ESM version, it's not clear to me how build tools are supposed to pick up on it, when the ESM modules aren't specified anywhere in the package.json. Out of 'main', 'module' and 'exports' only the 'main' field is filled out and it links to day.min.js, which is not ESM.

Expected behavior
Package.json should be updated to point to the modules inside ./esm/ through the module and exports fields

Information
irrelevant

@Bykiev
Copy link

Bykiev commented Aug 18, 2022

Hi, it seems to be really a bug and build tools most probably will use it as commonJS module. Can you please create a PR to fix it?

Upd: here is a discussion about esm support: #1765 , #1528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants