Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about dayjs.diff() Compatibility issues #338

Closed
youyinnn opened this issue Sep 13, 2018 · 2 comments
Closed

about dayjs.diff() Compatibility issues #338

youyinnn opened this issue Sep 13, 2018 · 2 comments

Comments

@youyinnn
Copy link

dayjs.min.js

at line:125

    // return n = e, Number.isNaN(parseFloat(n)) || !Number.isFinite(n) ? this : this.clone().mSet(t, e);
    return n = e, this.clone().mSet(t, e);

the api Number.isNaN & Number.isFinte is unsupport on ie
so it throw error on ie

@djhvscf
Copy link

djhvscf commented Sep 18, 2018

Number.isFinite polyfill

Number.isNaN polyfill

@iamkun
Copy link
Owner

iamkun commented Feb 2, 2019

I'll close this issue since it's been a while since it's been opened. Feel free to reopen if you have updates on this

@iamkun iamkun closed this as completed Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants