Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About performance #624

Closed
ls-v opened this issue Jul 8, 2019 · 2 comments
Closed

About performance #624

ls-v opened this issue Jul 8, 2019 · 2 comments

Comments

@ls-v
Copy link

ls-v commented Jul 8, 2019

1191562578827_ pic_hd
1201562578864_ pic_hd
One is the method I wrote myself, and one is dayjs. There's a big difference in performance
@ghost
Copy link

ghost commented Jul 8, 2019

@Likunone Vanilla js is of course and always the best in performance. However, a lib dose more than just a single date compare.

That is to say, there's no need for this comparison. Besides, Day.js is still fast enough even in your 300000 times tests.

@kirillgroshkov
Copy link

Fair comparison is with other Date libs (moment, luxon, date-fns, etc), not with vanilla js

@ls-v ls-v closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kirillgroshkov @ls-v