Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMM for 'ro' locale doesn't use monthsShort #736

Closed
mariusa opened this issue Nov 20, 2019 · 1 comment
Closed

MMM for 'ro' locale doesn't use monthsShort #736

mariusa opened this issue Nov 20, 2019 · 1 comment

Comments

@mariusa
Copy link

mariusa commented Nov 20, 2019

Describe the bug

monthsShort is properly defined in
https://github.com/iamkun/dayjs/blob/dev/src/locale/ro.js

and seems to be handled in
#457

but the short month for "Nov." is wrongly listed as "Noi":

require('dayjs/locale/ro')
console.log(
    dayjs()
        .locale('ro')
        .format('MMM')
)

Expected behavior
use monthsShort and output 'Nov.'

Information

  • Day.js 1.8.14
  • OS: linux
  • Browser nodejs 12
@mariusa
Copy link
Author

mariusa commented Nov 20, 2019

Works fine in 1.8.17

@mariusa mariusa closed this as completed Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mariusa