Fix uk (Ukrainian) locale month #899
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #899 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 166 167 +1
Lines 1388 1420 +32
Branches 295 301 +6
=========================================
+ Hits 1388 1420 +32
Continue to review full report at Codecov.
|
|
Please fix the unit test. |
|
@iamkun done |
| import uk from '../../src/locale/uk' | ||
| import '../../src/locale/zh-cn' | ||
|
|
||
| dayjs.extend(customParseFormat) | ||
| dayjs.extend(localizedFormat) | ||
| dayjs.extend(localeData) |
There was a problem hiding this comment.
I'm sorry, just removed
src/locale/uk.js
Outdated
| const monthFormat = 'січня_лютого_березня_квітня_травня_червня_липня_серпня_вересня_жовтня_листопада_грудня'.split('_') | ||
| const monthStandalone = 'січень_лютий_березень_квітень_травень_червень_липень_серпень_вересень_жовтень_листопад_грудень'.split('_') | ||
|
|
||
| const monthShortFormat = 'сiч_лют_бер_квiт_трав_черв_лип_серп_вер_жовт_лист_груд'.split('_') |
There was a problem hiding this comment.
there's no difference in monthShort, right?
There was a problem hiding this comment.
why not using the original monthsShort?
There was a problem hiding this comment.
for the same logic with long names
(I looked Russian locale file)
There was a problem hiding this comment.
There's no need actually.
You can just add monthFormat and monthStandalone
|
there's one lint error. 46:15 error Missing space before value for key 'monthsShort' |
|
Thanks |
|
🎉 This PR is included in version 1.8.28 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.8.28](iamkun/dayjs@v1.8.27...v1.8.28) (2020-05-28) ### Bug Fixes * Fix CustomParseFormat plugin month index error ([#918](iamkun/dayjs#918)) ([fa2ec7f](iamkun/dayjs@fa2ec7f)), closes [#915](iamkun/dayjs#915) * Update Ukrainian (uk) locale monthFormat and monthStandalone ([#899](iamkun/dayjs#899)) ([a08756e](iamkun/dayjs@a08756e))
## [1.8.28](iamkun/dayjs@v1.8.27...v1.8.28) (2020-05-28) ### Bug Fixes * Fix CustomParseFormat plugin month index error ([#918](iamkun/dayjs#918)) ([fa2ec7f](iamkun/dayjs@fa2ec7f)), closes [#915](iamkun/dayjs#915) * Update Ukrainian (uk) locale monthFormat and monthStandalone ([#899](iamkun/dayjs#899)) ([a08756e](iamkun/dayjs@a08756e))
Hi! Please, approve my pull request for uk (Ukrainian) locale. Thanks!